Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9968 sql: default sql.stats.statement_fingerprint.format_mask to use special flags #18514

Merged
merged 6 commits into from
May 16, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented May 2, 2024

Fixes DOC-9968, DOC-9894

(1) Added _includes/v23.2/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md.
(2) Added _includes/v24.1/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md and modified for this feature.
(3) In v23.2 and v24.1 ui-statements-page.md and ./cockroachcloud/statements-page.md, replace _includes/common/ui/statements-page.md with _includes/VERSION/ui/statement-fingerprints.md.
(4) In ./_includes/v24.1/ui/statements-table.md, replaced Failed? with Failure Count.

Rendered preview: SQL statement fingerprints section

…/_includes/common/ui/statements-page.md.

(2) Added _includes/v24.1/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md and modified for this feature.

(3) In v23.2 and v24.1 ui-statements-page.md and ./cockroachcloud/statements-page.md, replace _includes/common/ui/statements-page.md with _includes/VERSION/ui/statement-fingerprints.md.

(4) In ./_includes/v24.1/ui/statements-table.md, replaced Failed? with Failure Count.
Copy link

github-actions bot commented May 2, 2024

Files changed:

Copy link

netlify bot commented May 2, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 6c1c045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6646143aa2b91c00088e01df

Copy link

netlify bot commented May 2, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 6c1c045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6646143ab9bfd00008e8b15d

Copy link

netlify bot commented May 2, 2024

Netlify Preview

Name Link
🔨 Latest commit 6c1c045
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6646143a24b00d0008dc97ad
😎 Deploy Preview https://deploy-preview-18514--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl florence-crl requested a review from xinhaoz May 2, 2024 17:03
Copy link
Member

@xinhaoz xinhaoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for 23.2. 24.1 lgtm!

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

@florence-crl florence-crl requested a review from xinhaoz May 7, 2024 16:02
@florence-crl florence-crl requested a review from taroface May 8, 2024 21:01
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; some nits

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!

@florence-crl florence-crl merged commit 4ee0f69 into main May 16, 2024
6 checks passed
@florence-crl florence-crl deleted the DOC-9968 branch May 16, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants