-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-9968 sql: default sql.stats.statement_fingerprint.format_mask to use special flags #18514
Conversation
…/_includes/common/ui/statements-page.md. (2) Added _includes/v24.1/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md and modified for this feature. (3) In v23.2 and v24.1 ui-statements-page.md and ./cockroachcloud/statements-page.md, replace _includes/common/ui/statements-page.md with _includes/VERSION/ui/statement-fingerprints.md. (4) In ./_includes/v24.1/ui/statements-table.md, replaced Failed? with Failure Count.
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments for 23.2. 24.1 lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; some nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTRs!
Fixes DOC-9968, DOC-9894
(1) Added _includes/v23.2/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md.
(2) Added _includes/v24.1/ui/statement-fingerprints.md as a copy of ./_includes/common/ui/statements-page.md and modified for this feature.
(3) In v23.2 and v24.1 ui-statements-page.md and ./cockroachcloud/statements-page.md, replace _includes/common/ui/statements-page.md with _includes/VERSION/ui/statement-fingerprints.md.
(4) In ./_includes/v24.1/ui/statements-table.md, replaced Failed? with Failure Count.
Rendered preview: SQL statement fingerprints section